Re: [PATCH v2] firmware: coreboot: Don't register a pdev if screen_info data is present

From: Javier Martinez Canillas
Date: Fri Sep 13 2024 - 17:44:40 EST


Julius Werner <jwerner@xxxxxxxxxxxx> writes:

Hello Julius,

>> + /*
>> + * On Coreboot systems, the advertised LB_TAG_FRAMEBUFFER entry
>> + * in the Coreboot table should only be used if the payload did
>> + * not pass a framebuffer information to the Linux kernel.
>
> nit: The official brand spelling is "coreboot", always lowercase (even
> at the start of a sentence). Not a big deal though.
>
> Reviewed-by: Julius Werner <jwerner@xxxxxxxxxxxx>
>

Thanks for pointing that out, I wasn't aware. I just posted a v3 with
the proper coreboot spelling and your Reviewed-by tag collected.

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat