Re: [PATCH 08/21] dt-bindings: clock: adi,sc5xx-clocks: add bindings

[Rob Herring]

On Thu, Sep 12, 2024 at 07:24:53PM +0100, Arturs Artamonovs wrote:
> Add ADSP-SC5xx clock bindings.
> 
> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@xxxxxxxxxx>
> Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@xxxxxxxxxxx>
> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@xxxxxxxxxxx>
> Co-developed-by: Greg Malysa <greg.malysa@xxxxxxxxxxx>
> Signed-off-by: Greg Malysa <greg.malysa@xxxxxxxxxxx>
> ---
>  .../bindings/clock/adi,sc5xx-clocks.yaml           | 65 ++++++++++++++++++++++
>  1 file changed, 65 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/adi,sc5xx-clocks.yaml b/Documentation/devicetree/bindings/clock/adi,sc5xx-clocks.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..a092ebdefdcf89a635cdcf1073921efd28a38386
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/adi,sc5xx-clocks.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/adi,sc5xx-clocks.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Clock Tree Drivers for Analog Devices ADSP-SC5XX Processors
> +
> +maintainers:
> +  - Arturs Artamonovs <arturs.artamonovs@xxxxxxxxxx>
> +  - Utsav Agarwal <Utsav.Agarwal@xxxxxxxxxx>
> +
> +description: |
> +  These drivers read in the processors CDU (clock distribution unit)
> +  and CGU (clock generation unit) values to determine various clock
> +  rates

That sounds like 2 h/w blocks, not 1. If so, the bindings should reflect 
that even if you want 1 driver to handle both.

Rob