Re: [PATCH v1 1/2] uio: uio_dmem_genirq: Make use of irq_get_trigger_type()

From: Vasileios Amoiridis
Date: Fri Sep 13 2024 - 19:56:13 EST


On Fri, Sep 13, 2024 at 12:40:09PM +0300, Andy Shevchenko wrote:
> On Fri, Sep 13, 2024 at 01:59:24AM +0200, Vasileios Amoiridis wrote:
> > Convert the following case:
> >
> > struct irq_data *irq_data = irq_get_irq_data(irq);
> >
> > if (irq_data && irqd_get_trigger_type(irq_data) ... ) {
> > ...
> > }
> >
> > to the simpler:
> >
> > if (irq_get_trigger_type(irq) ... ) {
> > ...
> > }
> >
> > by using the irq_get_trigger_type() function.
>
> Btw, can you add a coccinelle ruleset for this?
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

Hi Andy!

Thanks for the time for the review! Yes, I would like to try it.

Cheers,
Vasilis