Re: [PATCH] kbuild: remove unnecessary export of RUST_LIB_SRC

[Nicolas Schier]

On Sat, Sep 14, 2024 at 03:06:20AM +0900, Masahiro Yamada wrote:
> If RUST_LIB_SRC is defined in the top-level Makefile (via an environment
> variable or command line), it is already exported.
> 
> The only situation where it is defined but not exported is when the
> top-level Makefile is wrapped by another Makefile (e.g., GNUmakefile).
> I cannot think of any other use cases.
> 
> I know some people use this tip to define custom variables. However,
> even in that case, you can export it directly in the wrapper Makefile.
> 
> Example GNUmakefile:
> 
>     export RUST_LIB_SRC = /path/to/your/sysroot/lib/rustlib/src/rust/library
>     include Makefile
> 
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> ---
> This code was added by this commit:
> 
>   https://github.com/Rust-for-Linux/linux/commit/3f46885dc03ed2d750085b2237078a1628323964
> 
> Please me know if I am missing something.

Looks good to me.

Reviewed-by: Nicolas Schier <nicolas@xxxxxxxxx>