Re: [PATCH net-next] net: ethernet: fs_enet: Make the per clock optional

[Christophe JAILLET]

Le 14/09/2024 à 10:18, Maxime Chevallier a écrit :
> Some platforms that use fs_enet don't have the PER register clock. This
> optional dependency on the clock was incorrectly made mandatory when
> switching to devm_ accessors.
>
> Reported-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> Closes: https://lore.kernel.org/netdev/4e4defa9-ef2f-4ff1-95ca-6627c24db20c@xxxxxxxxxx/
> Fixes: c614acf6e8e1 ("net: ethernet: fs_enet: simplify clock handling with devm accessors")
> Signed-off-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>
> ---
> This patch fixes a commit in net-next.
>
>   drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> index d300b01859a1..3425c4a6abcb 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> +++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> @@ -895,7 +895,7 @@ static int fs_enet_probe(struct platform_device *ofdev)
>   	 * but require enable to succeed when a clock was specified/found,
>   	 * keep a reference to the clock upon successful acquisition
>   	 */
> -	clk = devm_clk_get_enabled(&ofdev->dev, "per");
> +	clk = devm_clk_get_optional_enabled(&ofdev->dev, "per");
>   	if (IS_ERR(clk))
>   		goto out_free_fpi;
>   

Reviewed-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Thanks