Re: [PATCH v1 1/1] iio: light: ltr501: Drop most likely fake ACPI ID

[Jonathan Cameron]

On Sat, 14 Sep 2024 16:30:00 +0200
Hans de Goede <hdegoede@xxxxxxxxxx> wrote:

> Hi,
> 
> On 9/14/24 4:25 PM, Jonathan Cameron wrote:
> > On Fri, 13 Sep 2024 12:31:31 +0300
> > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >   
> >> On Thu, Sep 12, 2024 at 03:51:09PM +0200, Hans de Goede wrote:  
> >>> Hi,
> >>>
> >>> On 9/11/24 11:22 PM, Andy Shevchenko wrote:    
> >>>> The commit in question does not proove that ACPI ID exists.
> >>>> Quite likely it was a cargo cult addition while doint that
> >>>> for DT-based enumeration.  Drop most likely fake ACPI ID.
> >>>>
> >>>> Googling for LTERxxxx gives no useful results in regard to DSDT.
> >>>> Moreover, there is no "LTER" official vendor ID in the registry.
> >>>>
> >>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>    
> >>>
> >>> Thanks, patch looks good to me:    
> >>
> >> Have you grepped over your collection of real DSDTs?
> >>  
> >>> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>    
> >>
> >> Thank you!
> >>  
> > I'll pick these up in the meantime. Applied to the testing
> > branch of iio.git.  
> 
> As mentioned earlier today, at least the LTER0301 ACPI Hardware ID
> is real, so please drop this one. The kmx61 patch is fine to keep.
Done.

Thanks,

J
> 
> Regards,
> 
> Hans
> 
> 
>