Re: [PATCH net] netfilter: nft_socket: Fix a NULL vs IS_ERR() bug in nft_socket_cgroup_subtree_level()

From: Simon Horman
Date: Sat Sep 14 2024 - 11:22:08 EST

Next message: Simon Horman: "Re: [PATCH -next v4 1/2] posix-clock: Check timespec64 before call clock_settime()"
Previous message: kernel test robot: "[gustavoars:testing/wfamnae-next20240912 6/15] include/linux/compiler_types.h:517:45: error: call to '__compiletime_assert_838' declared with attribute error: BUILD_BUG_ON failed: conf->keylen < WLAN_KEY_LEN_CCMP"
In reply to: Florian Westphal: "Re: [PATCH net] netfilter: nft_socket: Fix a NULL vs IS_ERR() bug in nft_socket_cgroup_subtree_level()"
Next in thread: Pablo Neira Ayuso: "Re: [PATCH net] netfilter: nft_socket: Fix a NULL vs IS_ERR() bug in nft_socket_cgroup_subtree_level()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sat, Sep 14, 2024 at 01:19:40PM +0200, Florian Westphal wrote:
> Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> > The cgroup_get_from_path() function never returns NULL, it returns error
> > pointers. Update the error handling to match.
>
> Good news, I will retire in the next few years so I don't send shit
> patches anymore.
>
> Acked-by: Florian Westphal <fw@xxxxxxxxx>

Everyone makes mistakes, don't be too hard on yourself :)