Re: [PATCH v2] staging: octeon: Use new initialization api for tasklet

From: Abhishek Tamboli
Date: Sat Sep 14 2024 - 12:45:11 EST


Hi Greg,

On Sat, Sep 14, 2024 at 10:20:02AM +0200, Greg KH wrote:
> On Sat, Sep 14, 2024 at 12:47:34AM +0530, Abhishek Tamboli wrote:
> > Use the new api DECLARE_TASKLET instead of DECLARE_TASKLET_OLD
> > introduced in commit 12cc923f1ccc ("tasklet: Introduce new
> > initialization API").
>
> This says what you are doing, but not why you are doing this.
>
> Why is this needed? What bug does this fix? The code is the exact same
> afterward so why should this be accepted?
>
While this patch doesn't fix any functional bug, it ensures that the
code is kept up to date with the new Initialization API for tasklets.

Regards,
Abhishek