Re: [PATCH 01/21] arm64: Add ADI ADSP-SC598 SoC

From: Greg Kroah-Hartman
Date: Sat Sep 14 2024 - 13:56:27 EST


On Sat, Sep 14, 2024 at 07:15:08PM +0200, Markus Elfring wrote:
>
> > +++ b/drivers/soc/adi/system.c
> > @@ -0,0 +1,257 @@
>
> > +static void adi_system_config_remove(struct platform_device *pdev)
> +{
> > + struct adi_system_config *config = platform_get_drvdata(pdev);
> > + unsigned long flags;
> > +
> > + spin_lock_irqsave(&adi_system_config_lock, flags);
> > + list_del(&config->list);
> > + spin_unlock_irqrestore(&adi_system_config_lock, flags);
> > +}
>
>
> Under which circumstances would you become interested to apply a statement
> like “guard(spinlock_irqsave)(&adi_system_config_lock);”?
> https://elixir.bootlin.com/linux/v6.11-rc7/source/include/linux/spinlock.h#L572
>
> Regards,
> Markus
>


Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot