Re: [PATCH v4 0/5] Support alpha blending in MTK display driver

[Jason-JH Lin (林睿祥)]

On Fri, 2024-09-13 at 09:01 +0000, AngeloGioacchino Del Regno wrote:
> Il 13/09/24 07:40, Alper Nebi Yasak ha scritto:
> > Hi,
> > 
> > On 2024-09-13 05:56 +03:00, Jason-JH Lin (林睿祥) wrote:
> > > Hi Alper,
> > > 
> > > I think that's a platform issue because it works find in my
> > > MT8188
> > > platform, but I don't have any MT8173 platform.
> > > 
> > > Can you help me test the fix patch in your MT8173 platform?
> > > I'll provide a fix patch in 2 weeks via Google Chat.
> 
> Jason, Two weeks is a bit too late as CK already picked your series:
> reverting
> and reapplying creates noise in the commit log, and when this can be
> avoided it
> should be avoided.
> 
> Since upstream is broken, please understand that this fix should be
> developed
> with *highest* priority (so, as immediate as possible).
> 

OK, I'll send the fix path right away!

Regards,
Jason-JH.Lin

> Thanks,
> Angelo
> 
> > > 
> > > Regards,
> > > Jason-JH.Lin
> > 
> > I replied over Google Chat, but to make it clear for others on the
> > mailing list: Yes, I'll try to test patches when you send them.
> > 
> > > On Fri, 2024-09-13 at 01:25 +0000, CK Hu (胡俊光) wrote:
> > > > Hi, Jason:
> > > > 
> > > > Please help to fix this issue.
> > > > Otherwise, I would revert this series.
> > > > 
> > > > Regards,
> > > > CK
> > > > 
> > > > On Thu, 2024-09-12 at 23:29 +0300, Alper Nebi Yasak wrote:
> > > > >    
> > > > > External email : Please do not click links or open
> > > > > attachments
> > > > > until you have verified the sender or the content.
> > > > >   Hi,
> > > > > 
> > > > > On 2024-07-31 16:34 +03:00, Chun-Kuang Hu wrote:
> > > > > > Hi, Shawn:
> > > > > > 
> > > > > > Hsiao Chien Sung via B4 Relay
> > > > > > <devnull+shawn.sung.mediatek.com@xxxxxxxxxx> 於 2024年7月17日
> > > > > > 週三
> > > > > > 下午1:24寫道：
> > > > > > > 
> > > > > > > Support "Pre-multiplied" and "None" blend mode on
> > > > > > > MediaTek's
> > > > > > > chips by
> > > > > > > adding correct blend mode property when the planes init.
> > > > > > > Before this patch, only the "Coverage" mode (default) is
> > > > > > > supported.
> > > > > > 
> > > > > > For the whole series, applied to mediatek-drm-next [1],
> > > > > > thanks.
> > > > > > 
> > > > > > [1]
> > > > > > 
https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next__;!!CTRNKA9wMg0ARbw!jrw0cZrT-6A9bviBj9yX0zzeM2NAPin74zALZAajn9k92ZFrRVd3iZVOe0xpjsr21_Xw5v8KDeeF7nDtvT5rhRAMDV7KZ-qQ0Q$
> > > > > >  
> > > > > 
> > > > > I am seeing broken colors on an MT8173 Chromebook with next-
> > > > > 20240912,
> > > > > which goes away if I git-revert this series (commits
> > > > > 1f66fe62cc09
> > > > > eb17c5909481 a3f7f7ef4bfe 59e9d9de25f0 4225d5d5e779).
> > > > > 
> > > > > To illustrate, I took a picture [1] of some color mixing
> > > > > diagrams
> > > > > from
> > > > > Wikipedia [2]. Do you have an idea of what goes wrong?
> > > > > 
> > > > > (I'm busy with too many things so I don't want to debug it
> > > > > now...)
> > > > > 
> > > > > [1] 
> > > > > https://urldefense.com/v3/__https://i.imgur.com/tNFvovB.jpeg__;!!CTRNKA9wMg0ARbw!jrw0cZrT-6A9bviBj9yX0zzeM2NAPin74zALZAajn9k92ZFrRVd3iZVOe0xpjsr21_Xw5v8KDeeF7nDtvT5rhRAMDV42KYfvHA$
> > > > >  
> > > > > [2] 
> > > > > https://urldefense.com/v3/__https://en.wikipedia.org/wiki/Color_space*Generic__;Iw!!CTRNKA9wMg0ARbw!jrw0cZrT-6A9bviBj9yX0zzeM2NAPin74zALZAajn9k92ZFrRVd3iZVOe0xpjsr21_Xw5v8KDeeF7nDtvT5rhRAMDV67WeSFhQ$
> > > > >  
> 
>