Re: [PATCH v3 1/2] x86, KVM:SVM: Move sev specific parsing into arch/x86/virt/svm

[Paluri, PavanKumar]

Hello Boris,

On 9/12/2024 4:58 PM, Borislav Petkov wrote:
> On Thu, Sep 05, 2024 at 09:30:55AM -0500, Pavan Kumar Paluri wrote:
>> diff --git a/arch/x86/include/asm/sev-common.h b/arch/x86/include/asm/sev-common.h
>> index 98726c2b04f8..d3e7f97e2a4a 100644
>> --- a/arch/x86/include/asm/sev-common.h
>> +++ b/arch/x86/include/asm/sev-common.h
>> @@ -8,6 +8,9 @@
>>  #ifndef __ASM_X86_SEV_COMMON_H
>>  #define __ASM_X86_SEV_COMMON_H
>>  
>> +#include <asm/cache.h>
> 
> 
>> +#include <asm/pgtable_types.h>
> 
> What is that include for?
> 

This include was a part of the diff you suggested when we had a
discussion on including only those headers that provide the definitions
for the functions we use. Here's the link to that diff:

https://lore.kernel.org/all/20240829132438.GCZtB2lqeYpleYk9c4@fat_crate.local/

I included the diff as-is and looked beyond for any more changes needed.
Should've taken a look at why the above headers were necessary.

Now that I see, <asm/pgtable_types.h> is not really needed here. While
<asm/cache.h> is needed for __read_mostly.

I will fix this for v4.

Thank you for raising this question.

- Pavan