Re: [PATCH 4/8] pinctrl: qcom: Introduce IPQ5424 TLMM driver

[Sricharan Ramabadhran]

On 9/13/2024 6:09 PM, Dmitry Baryshkov wrote:
> On Fri, Sep 13, 2024 at 05:42:46PM GMT, Sricharan R wrote:
> > From: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
> >
> > The IPQ5424 SoC comes with a TLMM block, like all other Qualcomm
> > platforms, so add a driver for it.
> >
> > Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> > Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
>
> The order of trailers is strange. It lists you as an author, but then
> Varadarajan's SoB comes first and yours (authors) comes afterwards. If
> it was a joing effort, please use Co-developed-by tag in addition to SoB.
 ok, will add the co-developed.

> > ---
> >   drivers/pinctrl/qcom/Kconfig.msm       |   9 +
> >   drivers/pinctrl/qcom/Makefile          |   1 +
> >   drivers/pinctrl/qcom/pinctrl-ipq5424.c | 792 +++++++++++++++++++++++++
> >   3 files changed, 802 insertions(+)
> >   create mode 100644 drivers/pinctrl/qcom/pinctrl-ipq5424.c
>
> The rest LGTM
Thanks

Regards,
 Sricharan