Re: [PATCH 1/2] arm64: dts: sun50i-a64-pinephone: Add AF8133J to PinePhone

From: Andrey Skvortsov
Date: Sun Sep 15 2024 - 06:13:01 EST


Hi Chen-Yu Tsai,

On 24-09-09 16:08, Chen-Yu Tsai wrote:
> On Mon, Sep 9, 2024 at 5:48 AM Andrey Skvortsov
> <andrej.skvortzov@xxxxxxxxx> wrote:
> >
> > From: Icenowy Zheng <icenowy@xxxxxxx>
> >
> > New batches of PinePhones switched the magnetometer to AF8133J from
> > LIS3MDL because lack of ST components.
> >
> > Both chips use the same PB1 pin, but in different modes.
> > LIS3MDL uses it as an gpio input to handle interrupt.
> > AF8133J uses it as an gpio output as a reset signal.
> >
> > It wasn't possible at runtime to enable both device tree nodes and
> > detect supported sensor at probe time, because both drivers try to
> > acquire the same gpio in different modes.
> >
> > Device tree fixup will be done in firmware without introducing new board
> > revision and new dts.
>
> FYI I've been working on an in-kernel prober [1] for such alternative
> components. This does not require firmware support.
>
> [1] https://lore.kernel.org/all/20240904090016.2841572-1-wenst@xxxxxxxxxxxx/

Thank you for the information.

I've tried to use in-kernel prober from your v7 patchset [1] on top of
-next and it worked without any changes to firmware.

Since there is still on-going review of your patches it looks like
it's to early to submit my changes for review. But I'm ready to test
your new patches.

[1] https://lore.kernel.org/all/20240911072751.365361-1-wenst@xxxxxxxxxxxx/

--
Best regards,
Andrey Skvortsov