Re: [PATCH v3 6/6] i2c: npcm: Enable slave in eob interrupt

[Tyrone Ting]

Hi Andy:

Thank you for your feedback.

Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> 於 2024年9月13日 週五 下午6:29寫道：
>
> On Fri, Sep 13, 2024 at 06:15:32PM +0800, Tyrone Ting wrote:
> > From: Charles Boyer <Charles.Boyer@xxxxxxxxxxx>
> >
> > Nuvoton slave enable was in user space API call master_xfer, so it is
> > subject to delays from the OS scheduler. If the BMC is not enabled for
> > slave mode in time for master to send response, then it will NAK the
> > address match. Then the PLDM request timeout occurs.
> >
> > If the slave enable is moved to the EOB interrupt service routine, then
> > the BMC can be ready in slave mode by the time it needs to receive a
> > response.
>
> Fixes tag?
>
The patch is to reduce the time for the i2c module to behave as a target.
IOW, the i2c module target function will be ready earlier than it was.
So I remove the Fixes tag.

> --
> With Best Regards,
> Andy Shevchenko
>
>

Thank you.

Regards,
Tyrone