Re: [PATCH v2 2/4] dt-bindings: gpio: add support for NXP S32G2/S32G3 SoCs

From: Andrei Stefanescu
Date: Mon Sep 16 2024 - 02:01:55 EST


Hi Rob,

Thank you very much for the review!

>> +
>> + gpio-ranges:
>> + minItems: 2
>
> This gets expanded to 'maxItems: 2'. Is that what you want? If not,
> maxItems should be explicit.

Yes, 'maxItems: 2' is what I want but I can also add 'maxItems: 2' in v3 to be
explicit/more clear about it.

>> + - |
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + #include <dt-bindings/interrupt-controller/irq.h>
>> +
>> + gpio: siul2-gpio@4009d700 {
>
> gpio@...
>
> Drop unused label.

I will fix in v3.

Best regards,
Andrei