Re: [PATCH 12/21] dt-bindings: irqchip: adi,adsp-pint: add binding

From: Krzysztof Kozlowski
Date: Mon Sep 16 2024 - 02:57:43 EST


On 12/09/2024 20:24, Arturs Artamonovs via B4 Relay wrote:
> From: Arturs Artamonovs <arturs.artamonovs@xxxxxxxxxx>
>

You must always run checkpatch. We cannot take empty commit msgs, for
obvious reasons.

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Instead describe the hardware.


> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@xxxxxxxxxx>
> Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@xxxxxxxxxxx>
> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@xxxxxxxxxxx>
> Co-developed-by: Greg Malysa <greg.malysa@xxxxxxxxxxx>
> Signed-off-by: Greg Malysa <greg.malysa@xxxxxxxxxxx>
> ---
> .../interrupt-controller/adi,adsp-pint.yaml | 51 ++++++++++++++++++++++
> 1 file changed, 51 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/adi,adsp-pint.yaml b/Documentation/devicetree/bindings/interrupt-controller/adi,adsp-pint.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..b5ecf0cf1d2ceb580f45467ffe1550ae3280d1a3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/adi,adsp-pint.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/adi,adsp-pint.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices Port Pin Interrupt for SC5XX-family processors
> +
> +maintainers:
> + - Arturs Artamonovs <arturs.artamonovs@xxxxxxxxxx>
> + - Utsav Agarwal <Utsav.Agarwal@xxxxxxxxxx>
> +
> +description: |
> + Analog Devices Port Pin Interrupt driver for SC5XX-family processors
> +
> +properties:
> + compatible:
> + enum:
> + - adi,adsp-pint

All previous comments apply.

> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/clock/adi-sc5xx-clock.h>

Where do you user it?

> +
> + pint0: pint@31005000 {
> + compatible = "adi,adsp-pint";
> + reg = <0x31005000 0xFF>;
> + interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +

All previous comments apply.

> + pint1: pint@31005100 {
> + compatible = "adi,adsp-pint";
> + reg = <0x31005100 0xFF>;
> + interrupts = <GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +...
>

Best regards,
Krzysztof