Re: [PATCH] ARM: dts: microchip: Add trng labels for all at91 SoCs

[Nicolas Ferre]

Hi Alexander,

On 16/09/2024 at 08:42, Alexander Dahl wrote:
> SAM9X60 and SAMA7G5 already have those labels.  Add it for the other SoC
> families so it can be referenced in board files.
>
> Signed-off-by: Alexander Dahl <ada@xxxxxxxxxxx>

Thanks for the patch.

While we are at it, now that we have a proper label, can you please 
change the node name which should be "rng" ?

It will be aligned with latest Device Tree specification and what we 
tried to follow for newer sama7g5 for instance:

https://elixir.bootlin.com/linux/v6.10.10/source/arch/arm/boot/dts/microchip/sama7g5.dtsi#L774

Best regards,
  Nicolas

> ---
>   arch/arm/boot/dts/microchip/at91sam9g45.dtsi | 2 +-
>   arch/arm/boot/dts/microchip/sama5d2.dtsi     | 2 +-
>   arch/arm/boot/dts/microchip/sama5d3.dtsi     | 2 +-
>   arch/arm/boot/dts/microchip/sama5d4.dtsi     | 2 +-
>   4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/microchip/at91sam9g45.dtsi b/arch/arm/boot/dts/microchip/at91sam9g45.dtsi
> index 325c63a53118..02bd5a1833e8 100644
> --- a/arch/arm/boot/dts/microchip/at91sam9g45.dtsi
> +++ b/arch/arm/boot/dts/microchip/at91sam9g45.dtsi
> @@ -753,7 +753,7 @@ macb0: ethernet@fffbc000 {
>                                  status = "disabled";
>                          };
>
> -                       trng@fffcc000 {
> +                       trng: trng@fffcc000 {
>                                  compatible = "atmel,at91sam9g45-trng";
>                                  reg = <0xfffcc000 0x100>;
>                                  interrupts = <6 IRQ_TYPE_LEVEL_HIGH 0>;
> diff --git a/arch/arm/boot/dts/microchip/sama5d2.dtsi b/arch/arm/boot/dts/microchip/sama5d2.dtsi
> index 5f8e297e19ed..2fefe3efa769 100644
> --- a/arch/arm/boot/dts/microchip/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/microchip/sama5d2.dtsi
> @@ -1019,7 +1019,7 @@ AT91_XDMAC_DT_PER_IF(1) |
>                                  };
>                          };
>
> -                       trng@fc01c000 {
> +                       trng: trng@fc01c000 {
>                                  compatible = "atmel,at91sam9g45-trng";
>                                  reg = <0xfc01c000 0x100>;
>                                  interrupts = <47 IRQ_TYPE_LEVEL_HIGH 0>;
> diff --git a/arch/arm/boot/dts/microchip/sama5d3.dtsi b/arch/arm/boot/dts/microchip/sama5d3.dtsi
> index d4fc0c1dfc10..8335e0c8066f 100644
> --- a/arch/arm/boot/dts/microchip/sama5d3.dtsi
> +++ b/arch/arm/boot/dts/microchip/sama5d3.dtsi
> @@ -419,7 +419,7 @@ tdes: crypto@f803c000 {
>                                  clock-names = "tdes_clk";
>                          };
>
> -                       trng@f8040000 {
> +                       trng: trng@f8040000 {
>                                  compatible = "atmel,at91sam9g45-trng";
>                                  reg = <0xf8040000 0x100>;
>                                  interrupts = <45 IRQ_TYPE_LEVEL_HIGH 0>;
> diff --git a/arch/arm/boot/dts/microchip/sama5d4.dtsi b/arch/arm/boot/dts/microchip/sama5d4.dtsi
> index 58ceed997889..20b8a9b123e1 100644
> --- a/arch/arm/boot/dts/microchip/sama5d4.dtsi
> +++ b/arch/arm/boot/dts/microchip/sama5d4.dtsi
> @@ -658,7 +658,7 @@ macb1: ethernet@fc028000 {
>                                  status = "disabled";
>                          };
>
> -                       trng@fc030000 {
> +                       trng: trng@fc030000 {
>                                  compatible = "atmel,at91sam9g45-trng";
>                                  reg = <0xfc030000 0x100>;
>                                  interrupts = <53 IRQ_TYPE_LEVEL_HIGH 0>;
>
> base-commit: 98f7e32f20d28ec452afb208f9cffc08448a2652
> --
> 2.39.5