Re: [PATCH v2 3/4] gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs support

[Andrei Stefanescu]

Hi Markus,

On 14/09/2024 19:40, Markus Elfring wrote:
> …
>> +++ b/drivers/gpio/gpio-siul2-s32g2.c
>> @@ -0,0 +1,581 @@
> …
>> +static void siul2_gpio_set_direction(struct siul2_gpio_dev *dev,
>> +				     unsigned int gpio, int dir)
>> +{
>> +	unsigned long flags;
>> +
>> +	raw_spin_lock_irqsave(&dev->lock, flags);
> …
>> +	raw_spin_unlock_irqrestore(&dev->lock, flags);
>> +}
> …
> 
> Under which circumstances would you become interested to apply a statement
> like “guard(raw_spinlock_irqsave)(&dev->lock);”?
> https://elixir.bootlin.com/linux/v6.11-rc7/source/include/linux/spinlock.h#L551

Thank you very much for the suggestion! I will add it in v3.

> 
> Regards,
> Markus

Best regards,
Andrei