Re: [PATCH v2 1/5] dt-bindings: clock: qcom: Add compatible for QCM6490 boards

From: Krzysztof Kozlowski
Date: Mon Sep 16 2024 - 04:41:47 EST


On 13/09/2024 07:18, Taniya Das wrote:
>
>
> On 8/17/2024 2:51 PM, Krzysztof Kozlowski wrote:
>> On 16/08/2024 10:32, Taniya Das wrote:
>>> Add the new QCM6490 compatible to support the reset functionality for
>>> Low Power Audio subsystem.
>>>
>>> Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx>
>>
>> Subject is odd - I do not see here anything related to boards.
>>
>> Anyway, this is incomplete. Look at the rest of the binding - you did
>> not update any part related to proper clock constraints.
>>
>
> Not sure if I understand the concern, but I was of the opinion that I
> have added a new compatible for QCM6490 board , but no new clock
> constraint added.
>
>
> I see a patch from you
> https://lore.kernel.org/all/20240817094605.27185-1-krzysztof.kozlowski@xxxxxxxxxx/
> and I guess it fixes the constraints.
>

Look at entire file. This is incomplete.

Best regards,
Krzysztof