Re: [PATCH 1/2] dt-bindings: clock: spacemit: Add clock controlers of Spacemit K1 SoC

[Haylen Chu]

On Fri, Sep 06, 2024 at 05:51:44PM +0800, Chen Wang wrote:
> 
> On 2024/8/31 23:47, Haylen Chu wrote:
> > Add definition for the clock controllers of Spacemit K1 SoC. The clock
> > tree is managed by several SoC parts, thus different compatible strings
> > are added for each.
> > 
> > Signed-off-by: Haylen Chu <heylenay@xxxxxxxxxxx>
> > ---
> >   .../bindings/clock/spacemit,ccu.yaml          | 116 +++++++++++
> >   include/dt-bindings/clock/spacemit,ccu.h      | 197 ++++++++++++++++++
> >   2 files changed, 313 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/clock/spacemit,ccu.yaml
> >   create mode 100644 include/dt-bindings/clock/spacemit,ccu.h
> 
> Suggest to use format: <vendor name>,<soc name>-<clk name>, look at the
> files under Documentation/devicetree/bindings/clock
> 
> For example:
> 
> starfive,jh7110-pll
> 
> For your case:
> 
> spacemit,k1-xxx

Thanks for your advice.

> BTW, What's "CCU"?

The name is taken from vendor code and I think it should be "clock
control unit".

> > diff --git a/Documentation/devicetree/bindings/clock/spacemit,ccu.yaml b/Documentation/devicetree/bindings/clock/spacemit,ccu.yaml
> > new file mode 100644
> > index 000000000000..90ddfc5e2a2f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/spacemit,ccu.yaml
> > @@ -0,0 +1,116 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/spacemit,ccu.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Spacemit SoC Clock Controller
> > +
> > +maintainers:
> > +  - Haylen Chu <heylenay@xxxxxxxxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - spacemit,ccu-apbs
> > +      - spacemit,ccu-mpmu
> > +      - spacemit,ccu-apbc
> > +      - spacemit,ccu-apmu
> 
> Same as filename, compatible string should contain soc codename to differ
> from other soc of spacemit.