[PATCH] OPP: fix error code in dev_pm_opp_set_config()

From: Dan Carpenter
Date: Mon Sep 16 2024 - 10:10:30 EST


This is an error path so set the error code. Smatch complains about the
current code:

drivers/opp/core.c:2660 dev_pm_opp_set_config()
error: uninitialized symbol 'ret'.

Fixes: e37440e7e2c2 ("OPP: Call dev_pm_opp_set_opp() for required OPPs")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
drivers/opp/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/opp/core.c b/drivers/opp/core.c
index 494f8860220d..3aa18737470f 100644
--- a/drivers/opp/core.c
+++ b/drivers/opp/core.c
@@ -2630,8 +2630,10 @@ int dev_pm_opp_set_config(struct device *dev, struct dev_pm_opp_config *config)

/* Attach genpds */
if (config->genpd_names) {
- if (config->required_devs)
+ if (config->required_devs) {
+ ret = -EINVAL;
goto err;
+ }

ret = _opp_attach_genpd(opp_table, dev, config->genpd_names,
config->virt_devs);
--
2.45.2