Re: [PATCH] x86/ftrace: Include <asm/ptrace.h>

[Google]

On Mon, 16 Sep 2024 22:15:57 +0000
Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote:

> <asm/ftrace.h> uses struct pt_regs in several places. Include
> <asm/ptrace.h> to ensure it's visible. This is needed to make sure
> object files that only include <asm/asm-prototypes.h> compile.

Looks good to me.

Acked-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>

Thanks!

> 
> Suggested-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> Signed-off-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
> ---
>  arch/x86/include/asm/ftrace.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h
> index 0152a81d9b4a..b4d719de2c84 100644
> --- a/arch/x86/include/asm/ftrace.h
> +++ b/arch/x86/include/asm/ftrace.h
> @@ -2,6 +2,8 @@
>  #ifndef _ASM_X86_FTRACE_H
>  #define _ASM_X86_FTRACE_H
>  
> +#include <asm/ptrace.h>
> +
>  #ifdef CONFIG_FUNCTION_TRACER
>  #ifndef CC_USING_FENTRY
>  # error Compiler does not support fentry?
> 
> base-commit: ad060dbbcfcfcba624ef1a75e1d71365a98b86d8
> -- 
> 2.46.0.662.g92d0881bb0-goog
> 


-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>