Re: [PATCH v3] fs/exfat: resolve memory leak from exfat_create_upcase_table()

From: Namjae Jeon
Date: Tue Sep 17 2024 - 02:40:56 EST


On Tue, Sep 17, 2024 at 8:05 AM Daniel Yang <danielyangkang@xxxxxxxxx> wrote:
>
> If exfat_load_upcase_table reaches end and returns -EINVAL,
> allocated memory doesn't get freed and while
> exfat_load_default_upcase_table allocates more memory, leading to a
> memory leak.
>
> Here's link to syzkaller crash report illustrating this issue:
> https://syzkaller.appspot.com/text?tag=CrashReport&x=1406c201980000
>
> Signed-off-by: Daniel Yang <danielyangkang@xxxxxxxxx>
> Reported-by: syzbot+e1c69cadec0f1a078e3d@xxxxxxxxxxxxxxxxxxxxxxxxx
> ---
> V2 -> V3: free(NULL) is no-op, removed if() check
> V1 -> V2: Moved the mem free to create_upcase_table
Applied it to #dev now.
Thanks for your work!