Re: [PATCH ethtool-next 0/3] Add support for new features in C33 PSE
From: Kory Maincent
Date: Tue Sep 17 2024 - 04:12:31 EST
On Mon, 16 Sep 2024 22:11:28 +0200
Michal Kubecek <mkubecek@xxxxxxx> wrote:
> On Thu, Sep 12, 2024 at 11:20:01AM +0200, Kory Maincent wrote:
> [...]
>
> The series looks good, except for minor detail: the new parameter
> c33-pse-avail-pw-limit is documented in the manual page but is not shown
> in the "ethtool --help" output.
Oh indeed forgot the help usage text. Thanks for the review!
> As far as I can see, the kernel counterpart is present in 6.11 so that
> this series could technically go into ethtool 6.11 but as it was
> submitted so shortly before the release, I would rather leave it for the
> next cycle. As you submitted it against next branch, I assume you are OK
> with that but I better ask.
>
> For now I applied patch 2/3 which is a simple fix independent of the
> rest. Is it OK to apply the rest (with added help text) after the 6.11
> release?
It's ok for me to apply the rest after the 6.11 release.
Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com