Re: [PATCH V2 2/7] x86/mm: Drop page table entry address output from pxd_ERROR()

From: David Hildenbrand
Date: Tue Sep 17 2024 - 07:31:56 EST


On 17.09.24 13:19, Dave Hansen wrote:
On 9/17/24 03:22, David Hildenbrand wrote:
Not a big fan of all these "bad PTE" thingies ...

In general?

In general, after I learned that pmd_bad() fires on perfectly fine pmd_large() entries, which makes things like pmd_none_or_clear_bad() absolutely dangerous to use in code where we could have THPs ...

Consequently, we stopped using them in THP code, so what's the whole point of having them ...


Or not a big fan of the fact that every architecture has their own
(mostly) copied-and-pasted set?

Well, that most certainly as well :)

--
Cheers,

David / dhildenb