Re: [PATCH] usb: use mutex_lock in iowarrior_read()

From: Oliver Neukum
Date: Tue Sep 17 2024 - 09:17:38 EST


On 17.09.24 12:01, Jeongjun Park wrote:

Okay, I understand. Then I think it would be appropriate to do
the patch below to prevent blocking, but I have one question.

Currently, many misc usb drivers do not seem to handle the
O_NONBLOCK flag when using mutex_lock. If this is really

Yes. The quality of many drivers could be improved.
Feel free to make patches. However, the lack of quality elsewhere
does not justify a regression. Hence code fixing drivers already
correctly supporting O_NONBLOCK must be correct in that regard.

necessary code, I think it would require code modifications to
other functions inside iowarrior and many misc usb drivers.

What do you think about this?

The formatting seems to be broken. In terms of content it is good.

Regards
Oliver