Re: [PATCH v7 1/2] dt-bindings: iio: imu: smi240: add Bosch smi240
From: Krzysztof Kozlowski
Date: Tue Sep 17 2024 - 12:58:43 EST
On 13/09/2024 19:54, Conor Dooley wrote:
> On Fri, Sep 13, 2024 at 12:00:10PM +0200, Jianping.Shen@xxxxxxxxxxxx wrote:
>> From: Shen Jianping <Jianping.Shen@xxxxxxxxxxxx>
>>
>> add devicetree binding for Bosch imu smi240.
>> The smi240 is a combined three axis angular rate and
>> three axis acceleration sensor module.
>>
>> * The smi240 requires VDD and VDDIO
>> * Provides only spi interface.
>>
>> Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>
> 3 reviews? Doing well for yourself!
There is certainly mess here, but that's correct. We both reviewed older
version and then new version was posted ignoring our tags. So Rob gave
review.
Changelog is so vague that I have no clue...
Best regards,
Krzysztof