Re: [PATCH] cifs: Fix getting reparse points from server without WSL support
From: Pali Rohár
Date: Tue Sep 17 2024 - 17:07:19 EST
On Tuesday 17 September 2024 18:04:37 Paulo Alcantara wrote:
> Pali Rohár <pali@xxxxxxxxxx> writes:
>
> > Paulo, please look at this patch as it is related to WSL attributes
> > which you introduced in the mentioned commit. I think that the proper
> > fix should be to change SMB2_OP_QUERY_WSL_EA code to not trigger that
> > -EOPNOTSUPP error which is delivered to userspace. I just checked that
> > this my patch works fine for Native NTFS symlinks and NFS-style reparse
> > point special files.
>
> Thanks for the patch. The problem is that the client is considering
> that the entire compound request failed when the server doesn't support
> EA. The client should still parse the rest of the response that
> contains the getinfo and get reparse info data.
I agree with you. This sounds like the best option.
Would you be able to fix the client code to do this?