Re: [PATCH v2] usb: dwc3: core: Stop processing of pending events if controller is halted

From: Thinh Nguyen
Date: Tue Sep 17 2024 - 19:08:59 EST


++Joe Perches, Dwaipayan Ray

On Tue, Sep 17, 2024, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> On Tue, Sep 17, 2024 at 05:47:05AM +0000, Thinh Nguyen wrote:
> > On Tue, Sep 17, 2024, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> > > On Mon, Sep 16, 2024 at 11:00:30PM +0000, Thinh Nguyen wrote:
> > > > On Tue, Sep 17, 2024, Selvarasu Ganesan wrote:
> > > > > This commit addresses an issue where events were being processed when
> > > > > the controller was in a halted state. To fix this issue by stop
> > > > > processing the events as the event count was considered stale or
> > > > > invalid when the controller was halted.
> > > > >
> > > > > Fixes: fc8bb91bc83e ("usb: dwc3: implement runtime PM")
> > > > > Cc: stable <stable@xxxxxxxxxx>
> > > >
> > > > Checkpatch doesn't like that format. Fix the Cc stable tag to below:
> > > >
> > > > Cc: stable@xxxxxxxxxx
> > >
> > > What? Why? That should be fine, exactly what is the warning that this
> > > gives? That should be fine, as it's what my scripts put into patches
> > > that I create :)
> > >
> >
> > This is what checkpatch complains:
> >
> > WARNING:BAD_STABLE_ADDRESS_STYLE: Invalid email format for stable: 'stable <stable@xxxxxxxxxx>', prefer 'stable@xxxxxxxxxx'
> > #23:
> > Cc: stable <stable@xxxxxxxxxx>
> >
> > total: 0 errors, 1 warnings, 0 checks, 72 lines checked
>
> Ugh, that's wrong, whatever you want to do here is fine.
>
> Someone should send a patch for checkpatch...
>

I included the maintainer Joe and Dwaipayan base on the below related change:
fccaebf00e60 ("checkpatch: improve email parsing")

Seems checkpatch doesn't like stable address that begins with a name?
Hopefully they can help take a look.

Thanks,
Thinh