Re: [PATCH v5 2/3] dt-bindings: mfd: mediatek: mt6397: Convert to DT schema format

[Macpaul Lin]

On 9/17/24 15:00, Krzysztof Kozlowski wrote:

...

> On Mon, Sep 16, 2024 at 11:11:31PM +0800, Macpaul Lin wrote:
> > Convert the mfd: mediatek: mt6397 binding to DT schema format.
> >
> > MT6323, MT6358, and MT6397 are PMIC devices with multiple function
> > subdevices. They share a common PMIC design but have variations in
> > subdevice combinations.
> >
> > Key updates in this conversion:
>
> ...

[snip]

> > +
> > +            ldo_vcamio {
> > +                regulator-name = "vcamio";
> > +                regulator-min-microvolt = <1800000>;
> > +                regulator-max-microvolt = <1800000>;
> > +                regulator-enable-ramp-delay = <216>;
> > +            };
> > +        };
> > +
> > +        keys {
> > +            compatible = "mediatek,mt6323-keys";
> > +            mediatek,long-press-mode = <1>;
> > +            power-off-time-sec = <0>;
> > +
> > +            power {
> > +                    linux,keycodes = <116>;
>
> Messed indentation.

OOPS, I didn't find this during editing.
Will fix it in next version.

> > +
> > +        power-controller {
> > +            compatible = "mediatek,mt6323-pwrc";
> > +            #power-domain-cells = <0>;
> > +        };
> > +
> > +        rtc {
> > +            compatible = "mediatek,mt6323-rtc";
> > +        };
> > +    };
>
> Keep one complete example. Maybye two if they are significantly
> different, but I don't see these differences.

Okay, will keep complete example for mt6323.
Trimmed most similar part of mt6358 and mt6397.
Since there are some typical usage in other nodes.
Just keep these smaller nodes for mt6358 and mt6397.
Will also add a note of this in commit message.

> > +
> > +  - |
> > +    #include <dt-bindings/input/input.h>
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +    pmic {
> > +        compatible = "mediatek,mt6358">
>
>
> ....
>
> > -Required properties:
> > -- compatible: "mediatek,mt6397-pinctrl"
> > -For details, see ../pinctrl/pinctrl-mt65xx.txt
>
> Best regards,
> Krzysztof

Thanks!

Best regardsMacpaul Lin