Re: [PATCH] arm64: dts: qcom: qcs6460-rb3gen2: enable venus node

[Vedang Nagar]

Hi Luca,

On 9/18/2024 1:08 PM, Luca Weiss wrote:
> Hi Vedang!
> 
> On Tue Sep 17, 2024 at 11:24 AM CEST, Vedang Nagar via B4 Relay wrote:
>> From: Vedang Nagar <quic_vnagar@xxxxxxxxxxx>
>>
>> Enable the venus node on Qualcomm Rb3gen2 so that the
>> video decoder will start working.
>>
>> Signed-off-by: Vedang Nagar <quic_vnagar@xxxxxxxxxxx>
>> ---
>>  arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> index 0d45662b8028bff475024cff37c33e01d2ee251b..d52a7e0a35bf941c66ccaa00425147781976b359 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> @@ -790,6 +790,10 @@ &ufs_mem_phy {
>>  	status = "okay";
>>  };
>>  
>> +&venus {
>> +	status = "okay";
> 
> Don't you want to set firmware-name property here?
No, we don't need to set firmware-name property here, it will pick the default path from:
https://elixir.bootlin.com/linux/v6.11/source/drivers/media/platform/qcom/venus/core.c#L932

Regards,
Vedang Nagar
> 
> Regards
> Luca
> 
>> +};
>> +
>>  &wifi {
>>  	memory-region = <&wlan_fw_mem>;
>>  };
>>
>> ---
>> base-commit: 3f52e32445a1f63b788bc8969b7dc2386a80a24d
>> change-id: 20240917-venus_rb3_gen2-502e672d0e20
>> prerequisite-change-id: 20240913-qcm6490-clock-configs-0239f30babb5:v1
>> prerequisite-patch-id: faac726ebdf08240ab0913132beb2c620e52a98a
>>
>> Best regards,
>