Re: [PATCH V3 2/2] interconnect: qcom: add QCS8300 interconnect provider driver

From: Dmitry Baryshkov
Date: Wed Sep 18 2024 - 08:37:40 EST


On Wed, Sep 18, 2024 at 03:10:34PM GMT, Raviteja Laggyshetty wrote:
>
>
> On 9/11/2024 4:18 PM, Dmitry Baryshkov wrote:
> > On Tue, Sep 10, 2024 at 10:10:13AM GMT, Raviteja Laggyshetty wrote:
> >> Add driver for the Qualcomm interconnect buses found in QCS8300
> >> based platforms. The topology consists of several NoCs that are
> >> controlled by a remote processor that collects the aggregated
> >> bandwidth for each master-slave pairs.
> >>
> >> Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@xxxxxxxxxxx>
> >> ---
> >> drivers/interconnect/qcom/Kconfig | 11 +
> >> drivers/interconnect/qcom/Makefile | 2 +
> >> drivers/interconnect/qcom/qcs8300.c | 2088 +++++++++++++++++++++++++++
> >> drivers/interconnect/qcom/qcs8300.h | 177 +++
> >> 4 files changed, 2278 insertions(+)
> >> create mode 100644 drivers/interconnect/qcom/qcs8300.c
> >> create mode 100644 drivers/interconnect/qcom/qcs8300.h
> >
> > The driver looks pretty close to sa8775p one. Would it make sense to
> > have a single driver instead? Or would it complicate things
> > significantly?
> >
>
> Yes, the target is close to sa8775p. but there are differences in the topology and same driver cannot be used for both targets.

Ack

--
With best wishes
Dmitry