Re: [PATCH v6 2/2] dt-bindings: mfd: mediatek: mt6397: Convert to DT schema format

[Macpaul Lin]

On 9/18/24 19:56, Alexandre Belloni wrote:
> On 18/09/2024 13:51:51+0200, Alexandre Belloni wrote:
> > > Changes for v4:
> > >  - Remove "mediatek,mt6357" from PMIC's compatible string since there is a
> > >    seperated DT schema for PMIC mt6357.
> > > 
> > > Changes for v5:
> > >  - Rebase to next-20240913 (linux-next/master).
> > >  - Fix the "title" (device type) of mfd/mediatek,mt6397.yaml to "PMIC".
> > >  - RTC:
> > >   - Drop "start-year"
> >
> > Maybe, instead of dropping the property, you should add support in the
> > driver by setting range_min and range_max.
>
> Looking at this even more, the driver can probably be simplified by
> setting start_year in probe and dropping RTC_MIN_YEAR_OFFSET.

Thank you for pointing out where and how the driver should be changed.
However, I'm wondering if this should be a fix with a separated
patchset (bindings and the driver)? The board or SoC's device trees
should be reviewed as well. I'll need to get someone's help (permission) 
inside MediaTek to check those dts and construct the patch for RTC driver.
That will take sometime.

[snip]

Thanks.
Best Regards,
Macpaul Lin