RE: [EXT] Re: [PATCH] wifi: mwifiex: fix firmware crash for AP DFS mode

[David Lin]

> From: Kalle Valo <kvalo@xxxxxxxxxx>
> Sent: Thursday, September 19, 2024 1:58 AM
> To: Francesco Dolcini <francesco@xxxxxxxxxx>
> Cc: David Lin <yu-hao.lin@xxxxxxx>; l.stach@xxxxxxxxxxxxxx;
> linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> briannorris@xxxxxxxxxxxx; Pete Hsieh <tsung-hsien.hsieh@xxxxxxx>
> Subject: [EXT] Re: [PATCH] wifi: mwifiex: fix firmware crash for AP DFS mode
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> Francesco Dolcini <francesco@xxxxxxxxxx> writes:
> 
> > +Lucas (in case he missed this patch)
> >
> > On Fri, Aug 30, 2024 at 04:07:19PM +0800, David Lin wrote:
> >> Firmware crashes when AP works on a DFS channel and radar detection
> occurs.
> >> This patch fixes the issue, also add "fake_radar_detect" entry to
> >> mimic radar detection for testing purpose.
> >
> > Do we want such kind of "fake" code in the driver?
> 
> BTW in ath11k we have dfs_simulate_radar debugfs file for testing DFS, I
> assume this is something similar. So there are benefits from having it.
> 

Nice to know it.

> > I do not agree that we mix an actual bug fix with additional testing
> > code, and if I understand correctly the commit message this is what we
> > are doing here.
> 
> Yeah, we have a rule "one logical change per patch". So the debugfs addition
> needs to be in a separate patch.
> 

O.K. I will create another patch to add this debugfs file for radar detection test.

David