Re: [PATCH 1/2] dt-bindings: watchdog: airoha: document watchdog for Airoha EN7581

[Krzysztof Kozlowski]

On 19/09/2024 14:26, Christian Marangi wrote:
> Document watchdog for Airoha EN7581. This SoC implement a simple
> watchdog that supports a max timeout of 28 seconds.
> 
> The watchdog ticks on half the BUS clock and require the BUS frequency
> to be provided.

Clock provider should implement clk_get_rate()...

> 

...

> +maintainers:
> +  - Christian Marangi <ansuelsmth@xxxxxxxxx>
> +
> +allOf:
> +  - $ref: watchdog.yaml#
> +
> +properties:
> +  compatible:
> +    const: airoha,en7581-wdt
> +
> +  reg:
> +    maxItems: 1
> +
> +  clock-frequency:
> +    description: BUS frequency in Hz (timer ticks at half the BUS freq)
> +    const: 300000000

Which bus frequency? Aren't you missing here clock input?

Best regards,
Krzysztof