Re: [PATCH 0/2] drm/mediatek: Adjustments for mtk_gem_prime_vmap()

From: AngeloGioacchino Del Regno
Date: Thu Sep 19 2024 - 09:12:45 EST


Il 17/09/24 19:34, Markus Elfring ha scritto:
From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 17 Sep 2024 19:16:45 +0200

A few update suggestions were taken into account
from static source code analysis.

Hello Markus,

In my opinion, the suggested changes aren't bringing any improvement, not
in readability nor performance ... nor anything else, really.

For how I see it, the code is fine as it is, but then, that all boils down
to code style preferences and nothing else.

Cheers,
angelo


Markus Elfring (2):
Avoid duplicate sg_free_table(sgt) call
Use common error handling code

drivers/gpu/drm/mediatek/mtk_gem.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)

--
2.46.0