Re: [PATCH v2 1/5] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Document the X1E80100 QMP PCIe PHY Gen4 x8

[Qiang Yu]

On 9/16/2024 11:15 PM, Krzysztof Kozlowski wrote:
> On Fri, Sep 13, 2024 at 01:37:20AM -0700, Qiang Yu wrote:
> > PCIe 3rd instance of X1E80100 support Gen 4x8 which needs different 8 lane
> > capable QMP PCIe PHY. Document Gen 4x8 PHY as separate module.
> And this is really different hardware? Not just different number of lanes? We discussed it, but I don't see the explanation in commit msg.
Yes, PCIe3 use a different phy that supports 8 lanes and provides
additional register set, txz and rxz. It is not a bifurcation mode which
actually combines two same phys like PCIe6a. It's also not just different
number of lanes. Will explain this in commit msg.

Thanks,
Qiang
> > Signed-off-by: Qiang Yu <quic_qianyu@xxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml    | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
> > index dcf4fa55fbba..680ec3113c2b 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
> > @@ -41,6 +41,7 @@ properties:
> >         - qcom,x1e80100-qmp-gen3x2-pcie-phy
> >         - qcom,x1e80100-qmp-gen4x2-pcie-phy
> >         - qcom,x1e80100-qmp-gen4x4-pcie-phy
> > +      - qcom,x1e80100-qmp-gen4x8-pcie-phy
> >   
> >     reg:
> >       minItems: 1
> > @@ -172,6 +173,7 @@ allOf:
> >                 - qcom,sc8280xp-qmp-gen3x2-pcie-phy
> >                 - qcom,sc8280xp-qmp-gen3x4-pcie-phy
> >                 - qcom,x1e80100-qmp-gen4x4-pcie-phy
> > +              - qcom,x1e80100-qmp-gen4x8-pcie-phy
> >       then:
> >         properties:
> >           clocks:
> > @@ -201,6 +203,7 @@ allOf:
> >                 - qcom,sm8550-qmp-gen4x2-pcie-phy
> >                 - qcom,sm8650-qmp-gen4x2-pcie-phy
> >                 - qcom,x1e80100-qmp-gen4x2-pcie-phy
> Hm, why 4x4 is not here?
>
> Best regards,
> Krzysztof