Re: [PATCH RFC 1/6] block: Rework bio_split() return value

From: Johannes Thumshirn
Date: Thu Sep 19 2024 - 11:50:41 EST


On 19.09.24 11:25, John Garry wrote:
> - BUG_ON(sectors <= 0);
> - BUG_ON(sectors >= bio_sectors(bio));
> + if (WARN_ON(sectors <= 0))
> + return ERR_PTR(-EINVAL);
> + if (WARN_ON(sectors >= bio_sectors(bio)))
> + return ERR_PTR(-EINVAL);

Nit: WARN_ON_ONCE() otherwise it'll trigger endless amounts of
stacktraces in dmesg.