Re: [PATCH] soc: qcom: pd_mapper: fix ADSP PD maps

From: Dmitry Baryshkov
Date: Fri Sep 20 2024 - 04:50:03 EST


On Fri, Sep 20, 2024 at 10:21:03AM GMT, Johan Hovold wrote:
> On Wed, Sep 18, 2024 at 04:02:39PM +0300, Dmitry Baryshkov wrote:
> > On X1E8 devices root ADSP domain should have tms/pdr_enabled registered.
> > Change the PDM domain data that is used for X1E80100 ADSP.
>
> Please expand the commit message so that it explains why this is
> needed and not just describes what the patch does.

Unfortunately in this case I have no idea. It marks the domain as
restartable (?), this is what json files for CRD and T14s do. Maybe
Chris can comment more.

> What is the expected impact of this and is there any chance that this is
> related to some of the in-kernel pd-mapper regression I've reported
> (e.g. audio not being registered and failing with a PDR error)?
>
> https://lore.kernel.org/all/ZthVTC8dt1kSdjMb@xxxxxxxxxxxxxxxxxxxx/

Still debugging this, sidetracked by OSS / LPC.

>
> > Fixes: bd6db1f1486e ("soc: qcom: pd_mapper: Add X1E80100")
> > Cc: stable@xxxxxxxxxxxxxxx
>
> Since the offending commit has not reached mainline yet, there's no need
> for a stable tag.

Ack, nice.

--
With best wishes
Dmitry