Re: [PATCH] selftests: Makefile: create OUTPUT dir
From: Jakub Kicinski
Date: Fri Sep 20 2024 - 06:38:58 EST
On Thu, 19 Sep 2024 09:51:47 -0600 Shuah Khan wrote:
> > @@ -261,6 +261,7 @@ ifdef INSTALL_PATH
> > @ret=1; \
> > for TARGET in $(TARGETS) $(INSTALL_DEP_TARGETS); do \
> > BUILD_TARGET=$$BUILD/$$TARGET; \
> > + mkdir -p $$BUILD_TARGET; \
> > $(MAKE) OUTPUT=$$BUILD_TARGET -C $$TARGET install \
> > INSTALL_PATH=$(INSTALL_PATH)/$$TARGET \
> > SRC_PATH=$(shell readlink -e $$(pwd)) \
>
> Doesn't the "all" target mkdir work for this case? Why do we need another mkdir here?
I was wondering about that, too. Looks like the code from the all
target is copy/pasted in the install target except the mkdir line.
Best fix would be to make the dependency work, I don't understand
why it doesn't already, tho.