Re: [PATCH] net: mana: Add get_link and get_link_ksettings in ethtool

From: Erni Sri Satya Vennela
Date: Fri Sep 20 2024 - 08:49:38 EST


On Thu, Sep 19, 2024 at 09:45:53AM +0200, Jakub Kicinski wrote:
> On Tue, 17 Sep 2024 20:34:40 +0000 Haiyang Zhang wrote:
> > > Unless I'm misreading I don't see the answer to the "why?" in your
> > > reply.
> > >
> > > What benefit does reporting duplex on a virtual device bring?
> > > What kind of SW need this current patch?
> > > etc.
> >
> > I'm not aware of any SW has such requirement either.
> > We just want the "ethtool <nic>" cmd can output something we already know.
> > Is this acceptable?
>
> Yeah, that's fine, I was just curious.
Thankyou for the feedback. I will update these changes in the next
version of the patch.