Re: [PATCH] iommu/arm-smmu-v3: Convert comma to semicolon

From: Jason Gunthorpe
Date: Fri Sep 20 2024 - 08:50:26 EST


On Thu, Sep 19, 2024 at 12:45:18PM +0800, Baolu Lu wrote:
> On 9/19/24 11:53 AM, Chen Ni wrote:
> > Replace comma between expressions with semicolons.
> >
> > Using a ',' in place of a ';' can have unintended side effects.
> > Although that is not the case here, it is seems best to use ';'
> > unless ',' is intended.
> >
> > Found by inspection.
> > No functional change intended.
> > Compile tested only.
> >
> > Signed-off-by: Chen Ni<nichen@xxxxxxxxxxx>
> > ---
> > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> A typo in commit e3b1be2e73dbe ("iommu/arm-smmu-v3: Reorganize struct
> arm_smmu_ctx_desc_cfg").
>
> Reviewed-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>

Yes should have a fixes line, plese include and resend it..

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Jason