Re: [PATCH v2] platform/x86/intel/pmt: Correct the typo 'ACCCESS_LOCAL'

From: Ilpo Järvinen
Date: Fri Sep 20 2024 - 10:15:06 EST


On Fri, 20 Sep 2024, WangYuli wrote:

> There is a spelling mistake of 'ACCCESS_LOCAL' which should be
> 'ACCESS_LOCAL'.
>
> Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Suggested-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

Did I actually suggest the change this patch makes somewhere? I recall
noting the typo at one point myself but I don't remember telling anyone
about it.

Reviewing your patch does not itself count as a reason for adding
Suggested-by (unless the entire approach used in the patch is changed
because of a reviewer comment which is not the case here).

--
i.

> Link: https://lore.kernel.org/all/26b8f38f-ff32-81fb-bbe5-aa141239427e@xxxxxxxxxxxxxxx/
> Signed-off-by: WangYuli <wangyuli@xxxxxxxxxxxxx>
> ---
> drivers/platform/x86/intel/pmt/class.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/pmt/class.c b/drivers/platform/x86/intel/pmt/class.c
> index c04bb7f97a4d..7680474c4f96 100644
> --- a/drivers/platform/x86/intel/pmt/class.c
> +++ b/drivers/platform/x86/intel/pmt/class.c
> @@ -207,7 +207,7 @@ static int intel_pmt_populate_entry(struct intel_pmt_entry *entry,
> /*
> * Some hardware use a different calculation for the base address
> * when access_type == ACCESS_LOCAL. On the these systems
> - * ACCCESS_LOCAL refers to an address in the same BAR as the
> + * ACCESS_LOCAL refers to an address in the same BAR as the
> * header but at a fixed offset. But as the header address was
> * supplied to the driver, we don't know which BAR it was in.
> * So search for the bar whose range includes the header address.
>