Re: [PATCH] powerpc/kvm: Fix typo in the kvm functions

From: IBM
Date: Fri Sep 20 2024 - 11:07:29 EST


Kajol Jain <kjain@xxxxxxxxxxxxx> writes:

> Fix typo in the following kvm function names from:
>
> kmvhv_counters_tracepoint_regfunc -> kvmhv_counters_tracepoint_regfunc
> kmvhv_counters_tracepoint_unregfunc -> kvmhv_counters_tracepoint_unregfunc

Gr8 spotting!
It took sometime to realize k[mv] and k[vm] is the change :)

>
> Fixes: e1f288d2f9c6 ("KVM: PPC: Book3S HV nestedv2: Add support for reading VPA counters for pseries guests")

Right. This commit added the registration and unregistration helpers
for TRACE_EVEN_FN_COND tracepoint which mainly collects the
observability stats for nested guest on pseries.


> Reported-by: Madhavan Srinivasan <maddy@xxxxxxxxxxxxx>
> Signed-off-by: Kajol Jain <kjain@xxxxxxxxxxxxx>
> ---
> arch/powerpc/include/asm/kvm_book3s_64.h | 4 ++--
> arch/powerpc/kvm/book3s_hv.c | 4 ++--
> arch/powerpc/kvm/trace_hv.h | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)

Not an expert in kvm area. But the change looks very straight forward to
me. Searching for "kmv" string in arch/powerpc/ after applying this
patch indeed resulted in zero hits.

Please feel free to add -

Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx>