Re: [PATCH RFC 2/2] cpu/bugs: cgroup: Add a cgroup knob to bypass CPU mitigations

[Waiman Long]

On 9/20/24 03:54, Pawan Gupta wrote:
> > >    static int cpu_local_stat_show(struct seq_file *seq, void *v)
> > >    {
> > >    	struct cgroup __maybe_unused *cgrp = seq_css(seq)->cgroup;
> > > @@ -5290,6 +5326,12 @@ static struct cftype cgroup_base_files[] = {
> > >    		.name = "cpu.stat.local",
> > >    		.seq_show = cpu_local_stat_show,
> > >    	},
> > > +	{
> > > +		.name = "cpu.skip_mitigation",
> > > +		.flags = CFTYPE_NOT_ON_ROOT,
> > > +		.seq_show = cpu_skip_mitigation_show,
> > > +		.write = cgroup_skip_mitigation_write,
> > > +	},
> > >    	{ }	/* terminate */
> > >    };
> > Since this control knob is effective only for x86_64, should we enable this
> > only for this architecture?
> This should be under a CONFIG option that depends on the architecture
> selected. I don't see a reason why it will not be useful for other archs.

Using a CONFIG option looks fine to me. I just want to make sure that 
arches that don't support it won't have a useless control knob show up.

Cheers,
Longman