Re: drivers/spmi/spmi-pmic-arb.c:1782 spmi_pmic_arb_register_buses() error: uninitialized symbol 'ret'.

[Stephen Boyd]

Quoting Neil Armstrong (2024-09-18 03:34:22)
> On 18/09/2024 12:29, Dan Carpenter wrote:
> > 9799873717398e8 Abel Vesa 2024-05-07  1767    struct device_node *child;
> > 9799873717398e8 Abel Vesa 2024-05-07  1768    int ret;
> > 9799873717398e8 Abel Vesa 2024-05-07  1769
> > 9799873717398e8 Abel Vesa 2024-05-07  1770    /* legacy mode doesn't provide child node for the bus */
> > 9799873717398e8 Abel Vesa 2024-05-07  1771    if (of_device_is_compatible(node, "qcom,spmi-pmic-arb"))
> > 9799873717398e8 Abel Vesa 2024-05-07  1772            return spmi_pmic_arb_bus_init(pdev, node, pmic_arb);
> > 9799873717398e8 Abel Vesa 2024-05-07  1773
> > 9799873717398e8 Abel Vesa 2024-05-07  1774    for_each_available_child_of_node(node, child) {
> > 9799873717398e8 Abel Vesa 2024-05-07  1775            if (of_node_name_eq(child, "spmi")) {
> > 9799873717398e8 Abel Vesa 2024-05-07  1776                    ret = spmi_pmic_arb_bus_init(pdev, child, pmic_arb);
> > 9799873717398e8 Abel Vesa 2024-05-07  1777                    if (ret)
> > 9799873717398e8 Abel Vesa 2024-05-07  1778                            return ret;
> > 9799873717398e8 Abel Vesa 2024-05-07  1779            }
> > 9799873717398e8 Abel Vesa 2024-05-07  1780    }
> > 9799873717398e8 Abel Vesa 2024-05-07  1781
> > 9799873717398e8 Abel Vesa 2024-05-07 @1782    return ret;
> > 
> > Is it possible to not have an spmi node?
> 
> It's possible but not allowed per the bindings.
> 

Seems that we should just return 0 here then and squelch the warning.