Re: [PATCH] net: fjes: Refactor a string comparison in is_extended_socket_device()

[Simon Horman]

On Fri, Sep 20, 2024 at 02:24:50PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Fri, 20 Sep 2024 13:56:44 +0200
> 
> Assign the return value from a strncmp() call to a local variable
> so that an if statement can be omitted accordingly.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>

Hi Markus,

This is an old driver, that doesn't appear to have been under active
development for quite some time.  And I don't think that clean-ups of this
nature are worth the risk of regressions they might introduce.

If we can see bugs, let's fix them.
Else, let's leave it be.

-- 
pw-bot: rejected