Re: [PATCH] Fix dereferencing freed memory 'fw'

From: Dipendra Khadka
Date: Mon Sep 23 2024 - 04:46:00 EST


Hi Heikki,

On Mon, 23 Sept 2024 at 14:20, Heikki Krogerus
<heikki.krogerus@xxxxxxxxxxxxxxx> wrote:
>
> On Sun, Sep 22, 2024 at 10:52:11AM +0000, Dipendra Khadka wrote:
> > smatch reported dereferencing freed memory as below:
> > '''
> > drivers/usb/typec/tipd/core.c:1196 tps6598x_apply_patch() error: dereferencing freed memory 'fw'
> > '''
>
> This is only my opinion, but I don't like those '''single triple
> quotes''' in commit messages - they are just confusing. You don't need
> to use any kind of quotation marks in cases like this IMO.
>

Thanks for the feedback. I will send v2.

> thanks,
>
> --
> heikki

Best Regards,
Dipendra Khadka