RE: [PATCH] gpio: davinci: fix lazy disable

[J, KEERTHY]

-----Original Message-----
From: Francesco Dolcini <francesco@xxxxxxxxxx> 
Sent: Monday, September 23, 2024 3:10 PM
To: J, KEERTHY <j-keerthy@xxxxxx>; Bartosz Golaszewski <brgl@xxxxxxxx>
Cc: Parth Pancholi <parth105105@xxxxxxxxx>; Linus Walleij <linus.walleij@xxxxxxxxxx>; Emanuele Ghidoli <emanuele.ghidoli@xxxxxxxxxxx>; linux-gpio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Parth Pancholi <parth.pancholi@xxxxxxxxxxx>; stable@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] gpio: davinci: fix lazy disable

Hello Keerthy,

On Mon, Sep 02, 2024 at 02:08:30PM +0200, Bartosz Golaszewski wrote:
> On Wed, Aug 28, 2024 at 3:32 PM Parth Pancholi <parth105105@xxxxxxxxx> wrote:
> >
> > From: Emanuele Ghidoli <emanuele.ghidoli@xxxxxxxxxxx>
> >
> > On a few platforms such as TI's AM69 device, disable_irq()
> > fails to keep track of the interrupts that happen between
> > disable_irq() and enable_irq() and those interrupts are missed.
> > Use the ->irq_unmask() and ->irq_mask() methods instead
> > of ->irq_enable() and ->irq_disable() to correctly keep track of
> > edges when disable_irq is called.
> > This solves the issue of disable_irq() not working as expected
> > on such platforms.
> >
> > Fixes: 23265442b02b ("ARM: davinci: irq_data conversion.")
> > Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@xxxxxxxxxxx>
> > Signed-off-by: Parth Pancholi <parth.pancholi@xxxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> > ---
> 
> It looks good to me but I'd like to have an Ack from Keerthy on this.

Keerthy, just a gentle ping on this, can you help?

> Acked-by: Keerthy <j-keerthy@xxxxxx>

Francesco