Failed to load firmware error in radeon gpu driver code.

From: Vijay K Puliyala
Date: Mon Sep 23 2024 - 06:24:44 EST


We get Failed to load firmware error in radeon gpu driver code. This is compiler warning being treating as an error. I fixed it was by adding below diff.

error log :"radeon_cp: Failed to load firmware "%s"\n", fw_name);

diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c
index 0b1e19345f43..170404be09ae 100644
--- a/drivers/gpu/drm/radeon/r100.c
+++ b/drivers/gpu/drm/radeon/r100.c
@@ -1059,7 +1059,11 @@ static int r100_cp_init_microcode(struct radeon_device *rdev)

err = request_firmware(&rdev->me_fw, fw_name, rdev->dev);
if (err) {
- pr_err("radeon_cp: Failed to load firmware \"%s\"\n", fw_name);
+ if (fw_name) {
+ pr_err("radeon_cp: Failed to load firmware \"%s\"\n", fw_name);
+ } else {
+ pr_err("radeon_cp: Failed to load firmware (null)\n");
+ }
} else if (rdev->me_fw->size % 8) {
pr_err("radeon_cp: Bogus length %zu in firmware \"%s\"\n",
rdev->me_fw->size, fw_name);

Thanks
Vijay Kumar